Skip to content

[MINOR] Changed guava version to 19.0 for selenium test#1035

Closed
jongyoul wants to merge 1 commit into
apache:masterfrom
jongyoul:minor-upgrade-guava-for-selenium-with-safaridriver
Closed

[MINOR] Changed guava version to 19.0 for selenium test#1035
jongyoul wants to merge 1 commit into
apache:masterfrom
jongyoul:minor-upgrade-guava-for-selenium-with-safaridriver

Conversation

@jongyoul
Copy link
Copy Markdown
Member

@jongyoul jongyoul commented Jun 17, 2016

What is this PR for?

Enable selenium test with SafariDriver.

What type of PR is it?

[Bug Fix]

Todos

  • - Upgrade guava version

What is the Jira issue?

N/A

How should this be tested?

  1. Install selenium driver for Safari
  2. Make sure that you don't have firefox installed
  3. Start Zeppelin without this patch
  4. run a selenium test. TEST_SELENIUM="true" mvn package -DfailIfNoTests=false -pl 'zeppelin-interpreter,zeppelin-zengine,zeppelin-server' -Dtest=ParagraphActionsIT
  5. Got error
  6. Repeat after patch
  7. Success

Screenshots (if appropriate)

Got error like:

java.lang.NoSuchMethodError: com.google.common.util.concurrent.MoreExecutors.directExecutor()Ljava/util/concurrent/Executor;
    at org.openqa.selenium.safari.WebSocketConnection.send(WebSocketConnection.java:139)
    at org.openqa.selenium.safari.SafariDriverCommandExecutor.execute(SafariDriverCommandExecutor.java:188)
    at org.openqa.selenium.remote.RemoteWebDriver.execute(RemoteWebDriver.java:620)
    at org.openqa.selenium.remote.RemoteWebDriver.startSession(RemoteWebDriver.java:247)
    at org.openqa.selenium.remote.RemoteWebDriver.<init>(RemoteWebDriver.java:129)
    at org.openqa.selenium.remote.RemoteWebDriver.<init>(RemoteWebDriver.java:142)
    at org.openqa.selenium.safari.SafariDriver.<init>(SafariDriver.java:62)
    at org.openqa.selenium.safari.SafariDriver.<init>(SafariDriver.java:42)
    at org.apache.zeppelin.WebDriverManager.getWebDriver(WebDriverManager.java:103)
    at org.apache.zeppelin.integration.ParagraphActionsIT.startUp(ParagraphActionsIT.java:51)

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

@asfgit asfgit closed this in 8790ba9 Jun 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jongyoul